This repository was archived by the owner on Dec 8, 2024. It is now read-only.
Remove state from EXT-X-I-FRAME-STREAM-INF #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix done in reader.go was exactly as i added to the pull request so i know its working. |
|
Thanks @AyliD, your proposed PR helped narrow down the issue, see your other PR as to why I created this one instead. |
decodeLineOfMasterPlaylist is process a I-Frame line expecting the URI to be located on the next line, however, the EXT-X-I-FRAME-STREAM-INF attribute contains the URI as a tag (unlike EXT-X-STREAM-INF. This changes produces a test which reproduces the issue and also removes the state tracking for this attribute as it's not required.
grafov
pushed a commit
that referenced
this pull request
Nov 22, 2016
decodeLineOfMasterPlaylist is process a I-Frame line expecting the URI to be located on the next line, however, the EXT-X-I-FRAME-STREAM-INF attribute contains the URI as a tag (unlike EXT-X-STREAM-INF. This changes produces a test which reproduces the issue and also removes the state tracking for this attribute as it's not required.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decodeLineOfMasterPlaylist is processing an EXT-X-I-FRAME-STREAM-INF
line expecting the URI to be located on the next line, however, the
attribute contains the URI as a tag (unlike EXT-X-STREAM-INF).
This changes produces a test which reproduces the issue and also
removes the state tracking for this attribute as it's not required.
Fixes #46