Backport: [bugfix] Fix cache collision for incomplete query in SearchTagValuesV2 #5553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-elliott
reviewed
Aug 20, 2025
modules/ingester/instance_search.go
Outdated
| @@ -609,23 +609,23 @@ func includeBlock(b *backend.BlockMeta, req *tempopb.SearchRequest) bool { | |||
| // searchTagValuesV2CacheKey generates a cache key for the searchTagValuesV2 request | |||
| // cache key is used as the filename to store the protobuf data on disk | |||
| func searchTagValuesV2CacheKey(req *tempopb.SearchTagValuesRequest, limit int, prefix string) string { | |||
| query := req.Query | |||
| var cacheKey string | |||
There was a problem hiding this comment.
you should probably leave these changes off. they will conflict when we attempt to merge this to main. only make the change in the live store?
daaa9ba to
86d81d6
Compare
joe-elliott
approved these changes
Aug 20, 2025
e08c6f6
into
grafana:main-new-ingester
37 of 38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: backports #5549 for live-store to keep modules in sync
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]