TraceQL Metrics: right exemplars for histogram and quantiles (#5145) #5197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#5145) * Minor: remove forgotten comment * [Bugfix] TraceQL Metrics: right exemplars for histogram and quantiles * Test fixes: correct unmarshaller * Tests: send traces with different attributes * Tests: by operation * Test attribute values in exemplars * Changelog * Test attribute values in exemplars: additional cases * Benchmarks: HistogramAggregator.Combine * Minor review improvement
b09f8d4 to
958125a
Compare
joe-elliott
reviewed
Jun 2, 2025
| @@ -118,6 +118,7 @@ configurable via the throughput_bytes_slo field, and it will populate op="traces | |||
| * [BUGFIX] Reset `SkipMetricsGeneration` before reuse. [#5117](https://github.com/grafana/tempo/pull/5117) (@flxbk) | |||
| * [BUGFIX] Fix metrics generator host info processor overrides config. [#5118](https://github.com/grafana/tempo/pull/5118) (@rlankfo) | |||
| * [BUGFIX] Fix metrics generator target_info to skip attributes with no name to prevent downstream errors [#5148](https://github.com/grafana/tempo/pull/5148) (@mdisibio) | |||
| * [BUGFIX] TraceQL Metrics: right exemplars for histogram and quantiles [#5145](https://github.com/grafana/tempo/pull/5145) (@ruslan-mikhailov) | |||
There was a problem hiding this comment.
we don't have well defined process with regard to the changelog. ideally we'd show this being in rc.1 but i see that main already has this merged in 2.8.0-rc.0.
for now it's fine to leave this here. it will make my life easier when i fix the changelog in main and in the release branch.
joe-elliott
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Backport for #5145
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]