Skip to content

Update tools to use go version 1.24.2 #5057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 2, 2025
Merged

Update tools to use go version 1.24.2 #5057

merged 5 commits into from
May 2, 2025

Conversation

carsontham
Copy link
Contributor

@carsontham carsontham commented Apr 27, 2025 •
edited
Loading

What this PR does:

Which issue(s) this PR fixes:
Fixes #5040

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@carsontham carsontham marked this pull request as ready for review April 27, 2025 08:57
@joe-elliott
Copy link
Collaborator

Thanks! can we update the go.mod in tools as well?

https://github.com/grafana/tempo/blob/main/tools/go.mod

@carsontham
Copy link
Contributor Author

hi @joe-elliott, I have updated go.mod in tools. Thanks!

@stoewer
Copy link
Contributor

stoewer commented Apr 29, 2025

Thanks for contributing @carsontham
Currently the lint step is failing with the message:

ERRO Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: go.mod requires go >= 1.24.2 (running go 1.24.1; GOTOOLCHAIN=local)

To avoid this we usually update the go version with two separate PRs:

  1. Update Golang for tools. After merging, CI should push a new image tag to the registry. PR example: #4703.
  2. PR example: #4704.
    • Change TOOLS_IMAGE_TAG in build/tools.mk with the new tag.
    • Update the Go version

I suggest to turn this PR in the first one that only updates tools. It would be awesome if you could issue a second PR afterwards with the actual Go version updates

@carsontham carsontham mentioned this pull request Apr 30, 2025
Merged
3 tasks
@carsontham carsontham changed the title Update go version to 1.24.2 Update tools to use go version 1.24.2 Apr 30, 2025
@carsontham
Copy link
Contributor Author

hi @stoewer , i have updated this PR to do step 1 as mentioned above.
I also created another PR #5082 where i will continue step 2.

Thanks!

@stoewer stoewer merged commit ab783a4 into grafana:main May 2, 2025
17 checks passed
@stoewer
Copy link
Contributor

stoewer commented May 2, 2025

LGTM. If you like you can now move forward with #5082 (please also rebase)

@carsontham
Copy link
Contributor Author

Hi @stoewer , I have rebased and updated the PR #5082. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoewer stoewer stoewer approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio is a code owner

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@yvrhdn yvrhdn Awaiting requested review from yvrhdn yvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@javiermolinar javiermolinar Awaiting requested review from javiermolinar javiermolinar is a code owner

@carles-grafana carles-grafana Awaiting requested review from carles-grafana carles-grafana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carsontham @CLAassistant @joe-elliott @stoewer