Fix artificial delay override #5035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiermolinar
approved these changes
Apr 22, 2025
modules/overrides/config_test.go
Outdated
|
|
||
| // Skip certain fields that can be zero in valid configs | ||
| switch fieldName { | ||
| case "IngestionArtificialDelay": // Can legitimately be nil |
There was a problem hiding this comment.
what do you think about creating a static list of fieldNames. That way it would be easier to add new nil values to be skipped:
var skip = []string{"IngestionArtificialDelay"}
if slices.Contains(skip, fieldName) {
continue
}There was a problem hiding this comment.
For now it's just that field, but sounds good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR contains two changes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]