[release-v2.7] Fix querier panics #4901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix forIngesterRings Signed-off-by: Joe Elliott <number101010@gmail.com> * fix generators Signed-off-by: Joe Elliott <number101010@gmail.com> * refactor to pass the funcs in directly Signed-off-by: Joe Elliott <number101010@gmail.com> * fix breaks Signed-off-by: Joe Elliott <number101010@gmail.com> * improve error Signed-off-by: Joe Elliott <number101010@gmail.com> * got rid of metrics collector Signed-off-by: Joe Elliott <number101010@gmail.com> * chagnelog Signed-off-by: Joe Elliott <number101010@gmail.com> * fix found behavior Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> (cherry picked from commit 6d70705)
mdisibio
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6d70705 from #4790
What this PR does:
A panic was introduced here by abusing the ring forEach function to collect results. replicationSet.Do can return before all reads are complete if quorum is reached. Under certain, rare circumstances this caused the forEach function to modify a result here after it has already been returned and was being marshalled by the gRPC stack into proto.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]