-
Notifications
You must be signed in to change notification settings - Fork 597
Update OTEL Collector to v0.122.1 #4893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
joe-elliott
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a changelog entry and note the breaking change?
nice work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR Does
Breaking Changes
OpenTelemetry now enforces strict matching between receiver/exporter type and factory type. This is implemented here.
Receiver Name Changes
Receiver names are now more specific:
tempo/jaeger_receiver
jaeger/jaeger_receiver
Impact: This changes the
name
dimension for the following metrics:tempo_receiver_accepted_span
tempo_receiver_refused_spans
Other Changes
Tempo Query
Internal reference updates:
"github.com/jaegertracing/jaeger/plugin/storage/grpc/shared"
"jaeger_spanstore "github.com/jaegertracing/jaeger/storage/spanstore"
Translator/Jaeger
jaegerTrans.ThriftToTraces(batch)
now accepts batches of type*jaeger.Batch
Jaeger proto and models
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]