TraceQL Metrics: Vulture checks #4886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
758c196 to
c20aeb7
Compare
91db817 to
ab712af
Compare
3 tasks
cmd/tempo-vulture/main.go
Outdated
| } | ||
| timeSeries := resp.Series[0] | ||
| if timeSeries == nil { | ||
| tm.incorrectResult++ |
There was a problem hiding this comment.
Should we have incorrectResultMetrics?
There was a problem hiding this comment.
Makes sense. Changed
To be sure latest write is less than default ingestion_time_range_slack
7af4d0f to
369344b
Compare
|
+ review fix and minor changes in comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
it adds TraceQL Metrics check:
count_over_time()is not zeroWhich issue(s) this PR fixes
Fixes #
How it has been tested
Run tempo and vulture locally via docker-compose.
Results:
High amount of notfound_metrics due to bug: #4896
After the fix #4962, checked locally via docker-compose with Rhytm enabled and with one binary mode, Rhythm disabled. Additionally, run in k8s with Rhythm enabled
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]