rhythm: retry on commit error #4874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
reviewed
Mar 19, 2025
modules/blockbuilder/blockbuilder.go
Outdated
| if err == nil && commitOffsetErr == nil { | ||
| break | ||
| } | ||
| if !kerr.IsRetriable(commitOffsetErr) { |
There was a problem hiding this comment.
Do we need to see if err is retriable, and log commitOffsetErr? Finding the dual error handling a little unclear.
There was a problem hiding this comment.
CommitAllOffsets, yep looks better 👍
3 tasks
mdisibio
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
It implements a retry strategy to handle transient commit errors
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]