Skip to content

feat: Traceql metric sum_over_time #4786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 5, 2025

Conversation

javiermolinar
Copy link
Contributor

What this PR does:
It implements a new Traceql metric function to compute the sum over time

Other changes

  • Metric functions have been refactored
  • Fixed a typo in the MetricsEvaluator

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@javiermolinar javiermolinar added traceql type/docs Improvements or additions to documentation labels Mar 4, 2025
Co-authored-by: Ruslan Mikhailov <195758209+ruslan-mikhailov@users.noreply.github.com>
Copy link
Contributor

@mdisibio mdisibio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes lgtm. Thanks for the typo and lint cleanup too. Approving that, but let's finish up docs changes still.

javiermolinar and others added 2 commits March 5, 2025 09:37
@javiermolinar javiermolinar merged commit d71a556 into grafana:main Mar 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
traceql type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants