Fix metrics queries with unscoped attributes #4409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ped attrs present, add integration tests
|
Pushed a possible fix for |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes issues with using unscoped attributes in metrics queries: #3806 (comment)
The summary is that metrics queries do a lot of work to optimize away the engine callback, relying solely on storage predicate pushdowns. Unscoped queries like
{ .foo && .bar }were optimizing it away when they shouldn't.Unfortunately still thinking about the best fix for{ false } | rate(). To the storage layer it looks identical to{ true } | rate().Finally introduces some high-level metrics queries tests by writing test blocks with known frequencies of spans and querying them.
Which issue(s) this PR fixes:
Fixes #3806
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]