-
Notifications
You must be signed in to change notification settings - Fork 609
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededtype/bugSomething isn't workingSomething isn't working
Description
We are currently using a gauge incorrectly to report hedged roundtrips on both external endpoints and backend requests. This has worked in the past but recently we have seen this report erroneous results when rate()
ing in prometheus. It's possible it never worked correctly and we have only recently noticed. Regardless, it's bad practice and we should fix it.
External Hedged Requests Gauge
Shared code in use for both Gauges
Let's replace the two linked gauges above with counters.
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededtype/bugSomething isn't workingSomething isn't working