Skip to content

fix(v2): scheduler metrics collector panics #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2025
Merged

fix(v2): scheduler metrics collector panics #3990

merged 2 commits into from
Mar 12, 2025

Conversation

kolesnikovae
Copy link
Collaborator

I discovered a panic in the compaction scheduler stats collector. The issue is that the scheduler queue may have gaps in levels – this is a completely valid case that wasn’t taken into account:

github.com/grafana/pyroscope/pkg/experiment/metastore/compaction/scheduler.(*statsCollector).collectStats(0xc00090f740, 0xc0009c3f50)
/home/runner/work/pyroscope/pyroscope/pkg/experiment/metastore/compaction/scheduler/metrics.go:85 +0x185
/home/runner/work/pyroscope/pyroscope/pkg/experiment/metastore/compaction/scheduler/metrics.go:118 +0x7b

simonswine
simonswine approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolesnikovae kolesnikovae marked this pull request as ready for review March 12, 2025 05:15
@kolesnikovae kolesnikovae requested a review from a team as a code owner March 12, 2025 05:15
@kolesnikovae kolesnikovae merged commit 7592bbb into main Mar 12, 2025
21 checks passed
@kolesnikovae kolesnikovae deleted the fix/scheduler-collector-panics branch March 12, 2025 05:17
shelldandy pushed a commit to shelldandy/pyroscope that referenced this pull request Mar 14, 2025
@kolesnikovae @shelldandy
fix(v2): scheduler metrics collector panics (grafana#3990)
f8b91fd 
* fix(v2): scheduler metrics collector panics

* fix(v2): add scheduler metrics collector test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonswine simonswine simonswine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolesnikovae @simonswine