Skip to content

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Jun 7, 2022

What this PR does

I'm working on a experiment to deploy Mimir in simple scalable deployment mode (similar to Loki) and I'm finding myself copy-pasting some jsonnet. I would like to introduce some utilities.

In separate commits:

This PR is expected to be a no-op with regards to the generated manifests.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

pracucci added 3 commits June 7, 2022 14:23
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci force-pushed the add-jsonnet-utils branch from 07c6843 to 6ac63c4 Compare June 7, 2022 12:55
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. ❤️

@pracucci pracucci merged commit 8415eb1 into main Jun 7, 2022
@pracucci pracucci deleted the add-jsonnet-utils branch June 7, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants