[main] Update mimir-prometheus to 832330026356 #12032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Use the new NumFloatSamples and NumHistogramSample fields. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
d0cc735 to
1a9c9f7
Compare
krajorama
reviewed
Jul 9, 2025
…engine more closely
charleskorn
approved these changes
Jul 10, 2025
dimitarvdimitrov
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual follow-ups
@krajorama : I've updated the engine tests from upstream (prometheus/prometheus#16725). There was one that has a different error message with MQE so I only added it to ours tests. Maybe we want to fix the error message instead? Commented.
@krajorama : I've followed up the block stats changes (prometheus/prometheus#16824) by adding the necessary code in Mimir and also more tests. I've followed BlockStats.NumSamples to find all occurrences. Even if I wasn't successful , we don't actually use the new fields for anything critical - so this should be safe.
Update mimir-prometheus dependency
This PR was automatically created by the update-vendored-mimir-prometheus.yml workflow.
Details:
main609b9c7c04c18323300263566d178c6d571d985924fbd4270225609b9c7c04c1...8323300263566d178c6d571d985924fbd4270225