MQE: include additional information when panicking because estimated memory consumption is negative #11615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…memory consumption is negative
7bf0da0 to
fbcf221
Compare
bboreham
approved these changes
Jun 3, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-11615-to-r345 origin/r345
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 8139c71bb0ee9b8c66aea781b6c4cf0c37c4e01b
# Push it to GitHub
git push --set-upstream origin backport-11615-to-r345
git switch main
# Remove the local backport branch
git branch -D backport-11615-to-r345Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-11615-to-r341 origin/r341
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 8139c71bb0ee9b8c66aea781b6c4cf0c37c4e01b
# Push it to GitHub
git push --set-upstream origin backport-11615-to-r341
git switch main
# Remove the local backport branch
git branch -D backport-11615-to-r341Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-11615-to-r343 origin/r343
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 8139c71bb0ee9b8c66aea781b6c4cf0c37c4e01b
# Push it to GitHub
git push --set-upstream origin backport-11615-to-r343
git switch main
# Remove the local backport branch
git branch -D backport-11615-to-r343Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-11615-to-r344 origin/r344
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 8139c71bb0ee9b8c66aea781b6c4cf0c37c4e01b
# Push it to GitHub
git push --set-upstream origin backport-11615-to-r344
git switch main
# Remove the local backport branch
git branch -D backport-11615-to-r344Then, create a pull request where the |
Merged
1 task
charleskorn
added a commit
that referenced
this pull request
Jun 17, 2025
… becomes negative (#11713) #### What this PR does This PR adds the trace ID (if any) to the panic message used if the estimated memory consumption of a query becomes negative. #### Which issue(s) this PR fixes or relates to #11615, #11654 #### Checklist - [x] Tests updated. - [n/a] Documentation added. - [covered by #10067] `CHANGELOG.md` updated - the order of entries should be `[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. - [n/a] [`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md) updated with experimental features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
MQE panics when the estimated memory consumption of a query goes negative, as this indicates that something was returned to a pool multiple times, which could lead to incorrect query results.
However, when this happens in a production environment, it can be quite difficult to debug this, as it's often difficult to determine which query was affected: the panic often happens when
Query.Close()is called, which is not tracked by the activity tracker, and so the query doesn't appear in the list of inflight queries when the querier restarts.So, in this PR, I'm adding the query expression to the panic message to make it a bit easier to figure out what happened.
Which issue(s) this PR fixes or relates to
#10067
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.