MQE: fix possible panic while evaluating a query containing group_left or group_right
#11690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d panic if the binary operator is closed early
lamida
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
The change looks reasonable and tests seem covering all the edge cases now.
Follow up comment that can be done on the separate PR.
All instances of types.SomeSlicePool.Put(slice, ..) is always followed by setting slice = nil. Should we nil the slice inside the Put instead to avoid missed setting that up like this?
We can't nil the slice inside the |
charleskorn
added a commit
that referenced
this pull request
Jun 11, 2025
…ft` or `group_right` (#11690) (#11692) * Fix test names * Test case where operator is closed before any series are read * Fix issue where a query containing `group_left` or `group_right` could panic if the binary operator is closed early (cherry picked from commit db7d12b) Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
charleskorn
added a commit
that referenced
this pull request
Jun 11, 2025
…ft` or `group_right` (#11690) (#11695) * Fix test names * Test case where operator is closed before any series are read * Fix issue where a query containing `group_left` or `group_right` could panic if the binary operator is closed early (cherry picked from commit db7d12b) Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
charleskorn
added a commit
that referenced
this pull request
Jun 11, 2025
…ft` or `group_right` (#11690) (#11693) * Fix test names * Test case where operator is closed before any series are read * Fix issue where a query containing `group_left` or `group_right` could panic if the binary operator is closed early (cherry picked from commit db7d12b) Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
charleskorn
added a commit
that referenced
this pull request
Jun 11, 2025
…ft` or `group_right` (#11690) (#11696) * Fix test names * Test case where operator is closed before any series are read * Fix issue where a query containing `group_left` or `group_right` could panic if the binary operator is closed early (cherry picked from commit db7d12b) Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
charleskorn
added a commit
that referenced
this pull request
Jun 11, 2025
…ft` or `group_right` (#11690) (#11694) * Fix test names * Test case where operator is closed before any series are read * Fix issue where a query containing `group_left` or `group_right` could panic if the binary operator is closed early (cherry picked from commit db7d12b) Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
1 task
|
Another way to go would be to have This would be a bit more ugly in the code, but perhaps easier to use? |
1 task
charleskorn
added a commit
that referenced
this pull request
Jun 29, 2025
#### What this PR does This PR is an alternative to #11741, which implements an idea from @bboreham [here](#11690 (comment)). Compared to #11741, this avoids a need for a linter, at the cost of a slightly less obvious behaviour and slightly uglier code. #### Which issue(s) this PR fixes or relates to #11690 #### Checklist - [x] Tests updated. - [n/a] Documentation added. - [n/a] `CHANGELOG.md` updated - the order of entries should be `[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry is not needed, please add the `changelog-not-needed` label to the PR. - [n/a] [`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md) updated with experimental features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes an issue where queriers could panic with
estimated memory consumption of this query is negativewhile evaluating a query containing a one-to-many or many-to-one binary operation (akagroup_left/group_right).Specifically, the issue is triggered if all of the series with the same group matching labels on the "one" side are read and then the operator is closed before all of the corresponding output series have been emitted. (This can happen if, for example, the query contains further binary operations that only need a subset of the output series.)
In this case, the
matchGroup'spresenceslice would be returned to the pool multiple times: once inupdateOneSidePresence, and again whenoneSide.Closewas called by the first remaining output series in that group.Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.