MQE: fix issue where benchmark tool could run unexpected benchmarks #11188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes an issue where the MQE benchmarking tool could run benchmarks that did not match the provided filter, or run multiple benchmarks in the same process, producing incorrect peak memory consumption data.
This happens because
go test
's-bench
flag takes the value provided and splits it on/
, then treats each part as a separate regex. This is problematic when using a name likeBenchmarkQuery/a_100, instant query/engine=Mimir
, as this will match any benchmark witha_100, instant query
in the second part (eg.1 + a_100, instant query
). So we need to ensure that each part is set to match the full string of that part.Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.