Skip to content

MQE: remove unneeded feature toggles #11002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

MQE: remove unneeded feature toggles #11002

merged 1 commit into from
Mar 26, 2025

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Mar 26, 2025 •
edited
Loading

What this PR does

This PR removes most of the feature toggles for individual features in MQE, as we're now satisfied with the stability of these features.

The only exception is the "disabled functions" toggle, as we're still working on holt_winters / double_exponential_smoothing in #10873.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • [covered by Mimir Query Engine #10067] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn mentioned this pull request Mar 26, 2025
Open
@charleskorn charleskorn marked this pull request as ready for review March 26, 2025 00:22
@charleskorn charleskorn requested review from tacole02 and a team as code owners March 26, 2025 00:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

💻 Deploy preview deleted.

@charleskorn charleskorn merged commit aa2d364 into main Mar 26, 2025
28 checks passed
@charleskorn charleskorn deleted the charleskorn/mqe-feature-flags branch March 26, 2025 02:17
@charleskorn charleskorn mentioned this pull request Apr 15, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhesketh jhesketh jhesketh approved these changes

@tacole02 tacole02 Awaiting requested review from tacole02 tacole02 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskorn @jhesketh