Skip to content

Conversation

charleskorn
Copy link
Contributor

What this PR does

This PR fixes the issue where the parser.Statement returned by a MQE Query does not have the correct lookback delta set if the engine default or global default is being used.

As far as I can see, nothing uses this information, so there was no impact to this, but wanted to tidy it up before it did cause a problem.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • [covered by Mimir Query Engine #10067] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review March 25, 2025 03:14
@charleskorn charleskorn requested a review from a team as a code owner March 25, 2025 03:14
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Just one suggestion

@charleskorn charleskorn merged commit 32e2a94 into main Mar 25, 2025
26 checks passed
@charleskorn charleskorn deleted the charleskorn/lookback-delta branch March 25, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants