Skip to content

Conversation

jhesketh
Copy link
Contributor

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@jhesketh jhesketh requested a review from a team as a code owner March 14, 2025 01:25
@jhesketh jhesketh mentioned this pull request Mar 14, 2025
4 tasks
@jhesketh jhesketh enabled auto-merge (squash) March 14, 2025 01:26
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make the same change to AggregationGroup.AccumulateSeries and all the other implementations as well?

@jhesketh jhesketh mentioned this pull request Mar 14, 2025
@jhesketh
Copy link
Contributor Author

Could you please make the same change to AggregationGroup.AccumulateSeries and all the other implementations as well?

I checked for others by had a typo in my grep and didn't notice I missed them :-(. I knew there were more! Will get those sorry.

@jhesketh jhesketh force-pushed the jhesketh/mqe-rename-emitAnnotation branch from 2957158 to 0a9ed40 Compare March 14, 2025 02:14
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this

@jhesketh jhesketh merged commit d25a887 into grafana:main Mar 14, 2025
28 checks passed
@jhesketh jhesketh deleted the jhesketh/mqe-rename-emitAnnotation branch March 14, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants