MQE: add support for predict_linear
#10503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a553906 to
8893f16
Compare
jhesketh
reviewed
Jan 29, 2025
| fHead, fTail := step.Floats.UnsafePoints() | ||
|
|
||
| if len(fHead)+len(fTail) == 1 && step.Histograms.Any() { | ||
| if step.Floats.Any() && step.Histograms.Any() { |
There was a problem hiding this comment.
I wonder if we should address the annotations for deriv in a separate PR given the functionality change.
There was a problem hiding this comment.
Not sure I follow sorry - which functionality are you referring to?
There was a problem hiding this comment.
This PR changes the pre-existing deriv function in how it handles annotations. It might be easier to review if we do that separately first as its own PR. That said, I'm okay doing it here if you prefer.
There was a problem hiding this comment.
I think the changes are minor enough that a separate PR is not necessary.
Added in 63f59a7. |
63f59a7 to
ce747ee
Compare
jhesketh
approved these changes
Feb 3, 2025
ce747ee to
328d798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds support in MQE for
predict_linear.Which issue(s) this PR fixes or relates to
Part of #10067
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.