Skip to content

Conversation

charleskorn
Copy link
Contributor

What this PR does

This PR addresses some feedback on the tests added in #10533.

Which issue(s) this PR fixes or relates to

#10067, #10533

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • [covered by Mimir Query Engine #10067] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review February 2, 2025 23:51
@charleskorn charleskorn requested a review from a team as a code owner February 2, 2025 23:51
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charleskorn charleskorn merged commit 4ad7c7d into main Feb 3, 2025
28 checks passed
@charleskorn charleskorn deleted the charleskorn/10533-feedback branch February 3, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants