MQE: mangle native histograms in returned slices to catch use-after-return bugs + fix issues found #10010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
fad9a56 to
d59e928
Compare
jhesketh
reviewed
Nov 25, 2024
|
|
||
| h.ZeroCount = 12345678 | ||
| h.Count = 12345678 | ||
| h.Sum = 12345678 |
There was a problem hiding this comment.
(nit) it's very unlikely, but if we write a test with these values elsewhere the mangle won't work. Maybe for just one of these (eg Sum) we multiply it or similar.
Suggested change
| h.Sum = 12345678 | |
| h.Sum = h.Sum * 9.87654321 |
There was a problem hiding this comment.
I'm keen to keep this as simple as possible and to make the resulting histogram easy to identify. I think the likelihood of us using a histogram with these values elsewhere and also having a bug that is then hidden because of that is very, very unlikely, as you say.
There was a problem hiding this comment.
Fair enough, I don't hold this strongly.
jhesketh
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR extends MQE's tests to aid in catching native histogram use-after-return bugs, and fixes some issues they've uncovered.
Now, during tests in the
streamingpromqlpackage, any histograms in slices returned to theHPointorFloatHistogrampools will immediately be mutated. This ensures that any possible use-after-return bugs are triggered deterministically.Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.