MQE: only reduce resolution of delta in rate and increase once
#9531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jhesketh
reviewed
Oct 7, 2024
| if p.H.Schema < delta.Schema { | ||
| delta = delta.CopyToSchema(p.H.Schema) | ||
| if p.H.Schema < desiredSchema { | ||
| desiredSchema = p.H.Schema |
There was a problem hiding this comment.
do we need to copy delta to the desired schema at each counter reset (ie before adding the previous value)?
There was a problem hiding this comment.
No - Add handles the case where the histograms have different schemas and will return a histogram with the lower of the two schemas (ie. the lower resolution).
There was a problem hiding this comment.
Thanks, forgot about that.
jhesketh
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR modifies the behaviour of
rateandincreaseto only reduce the resolution of the computed delta once, rather than every time the schema reduces in the input range.This has no noticeable performance impact in our benchmarks as we don't exercise this case, as it rarely happens in practice.
Which issue(s) this PR fixes or relates to
Follow up to #9518 (comment)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.