Skip to content

Conversation

jhesketh
Copy link
Contributor

@jhesketh jhesketh commented Sep 20, 2024

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@jhesketh jhesketh requested a review from a team as a code owner September 20, 2024 02:22
@jhesketh jhesketh force-pushed the jhesketh/mqe-aggregations-group branch from 787bf42 to 8414b47 Compare September 20, 2024 03:08
@jhesketh jhesketh enabled auto-merge (squash) September 20, 2024 03:38
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It'd be good to see some benchmarks for group and count, but this shouldn't block this PR - we can always come back to it after merging.

@jhesketh jhesketh merged commit 3e06d8a into grafana:main Sep 20, 2024
29 checks passed
@jhesketh jhesketh deleted the jhesketh/mqe-aggregations-group branch September 20, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants