Skip to content

MQE: Handle min/max NaN's same as promql #9212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 6, 2024
Merged

MQE: Handle min/max NaN's same as promql #9212

merged 3 commits into from
Sep 6, 2024

Conversation

jhesketh
Copy link
Contributor

@jhesketh jhesketh commented Sep 6, 2024 •
edited
Loading

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@jhesketh jhesketh requested a review from a team as a code owner September 6, 2024 01:56
charleskorn
charleskorn approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this 🚀

@jhesketh jhesketh enabled auto-merge (squash) September 6, 2024 02:35
@jhesketh jhesketh merged commit 36b193c into grafana:main Sep 6, 2024
29 checks passed
@jhesketh jhesketh deleted the jhesketh/mqe-aggregations-nan branch September 6, 2024 04:47
@charleskorn charleskorn mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskorn charleskorn charleskorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhesketh @charleskorn