Mimir query engine: add support for vector() and scalar()
#9017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhesketh
reviewed
Aug 16, 2024
| }) | ||
| } | ||
|
|
||
| for seriesIdx := 0; seriesIdx < seriesCount; seriesIdx++ { |
There was a problem hiding this comment.
Why do this instead of looping until we see EOS?
There was a problem hiding this comment.
I did it this way so we could detect a situation where the inner operator said it would give X series but only returned Y series.
Granted, that should never happen, but if it did, that'd be weird and we'd want to fail the query rather than silently continue.
3185849 to
ae8670a
Compare
jhesketh
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR builds on #8995 to add support for the
vector()andscalar()functions in MQE.Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.