Skip to content

Mimir query engine: add feature toggle for binary operations #8872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2024
Merged

Mimir query engine: add feature toggle for binary operations #8872

merged 3 commits into from
Aug 1, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Aug 1, 2024 •
edited
Loading

What this PR does

This PR adds a feature toggle to enable or disable evaluating binary operations with MQE.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

jhesketh
jhesketh approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm sans linting :-)

@charleskorn charleskorn marked this pull request as ready for review August 1, 2024 04:47
@charleskorn charleskorn requested review from tacole02 and a team as code owners August 1, 2024 04:47
@charleskorn charleskorn enabled auto-merge (squash) August 1, 2024 05:12
@charleskorn charleskorn merged commit d2dbb3a into main Aug 1, 2024
29 checks passed
@charleskorn charleskorn deleted the charleskorn/mqe-binop-feature-toggle branch August 1, 2024 05:20
@charleskorn charleskorn mentioned this pull request Aug 13, 2024
Merged
1 task
@charleskorn charleskorn mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhesketh jhesketh jhesketh approved these changes

@tacole02 tacole02 Awaiting requested review from tacole02 tacole02 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskorn @jhesketh