-
Notifications
You must be signed in to change notification settings - Fork 634
MQE: Add support for rate on native histograms #8577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor suggestion.
How does performance compare with Prometheus' engine?
Benchmark of this branch:
TL;DR: Promising 20-40% less CPU. 20% less memory (with one case showing 70% less if correct). |
Could you please add a benchmark that compares Also, how do the |
I was obviously looking at the wrong thing previously :-(. With the correct tests in place, the results are not promising. I'll need to investigate why, but the most obvious contender is that we copy the histograms.
|
instead of needing to assign a new one.
Comparison between the engines of this branch:
|
Benchmark of this branch vs main:
|
What this PR does
Add support for
rate
function on native histograms.Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.