Skip to content

added streamable-http support #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2025
Merged

added streamable-http support #171

merged 3 commits into from
Jun 11, 2025

Conversation

ambhojgoyal
Copy link
Contributor

Add Streamable HTTP Mode Support for MCP Server

Summary

Introduces streamable HTTP mode for the MCP server, enabling real-time streaming of responses over HTTP connections.

Compatibility

Fully backward compatible - existing non-streaming clients continue to work unchanged.

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ambhojgoyal ambhojgoyal marked this pull request as ready for review June 11, 2025 12:36
@ambhojgoyal ambhojgoyal requested a review from a team as a code owner June 11, 2025 12:36
sd2k
sd2k requested changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@sd2k sd2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ambhojgoyal, thanks for the contribution, it looks decent. I added an inline comment on the base-path flag, but otherwise the only thing I'd like are some end-to-end tests for this (see the 'tests' directory) and it might be tricky for you to iterate (since they don't run in CI on forks 😱). Let me know if you're up to adding them, if not I can take a look.

@sd2k sd2k added the enhancement New feature or request label Jun 11, 2025
@sd2k sd2k self-assigned this Jun 11, 2025
sd2k
sd2k reviewed Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@sd2k sd2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ambhojgoyal
Copy link
Contributor Author

Hi @ambhojgoyal, thanks for the contribution, it looks decent. I added an inline comment on the base-path flag, but otherwise the only thing I'd like are some end-to-end tests for this (see the 'tests' directory) and it might be tricky for you to iterate (since they don't run in CI on forks 😱). Let me know if you're up to adding them, if not I can take a look.

Hey @sd2k
Was not able to get much hang of things here, will appreciate if you can help me out here

sd2k
sd2k approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@sd2k sd2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'll add some e2e tests in a followup PR to avoid polluting this one. Thanks again 👍

@sd2k sd2k enabled auto-merge (squash) June 11, 2025 20:52
@sd2k sd2k merged commit d4f71c5 into grafana:main Jun 11, 2025
10 checks passed
@ambhojgoyal ambhojgoyal deleted the http-streamable-support branch June 11, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sd2k sd2k sd2k approved these changes

Assignees

@sd2k sd2k

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ambhojgoyal @CLAassistant @sd2k