refactor: consolidate Grafana configuration into GrafanaConfig struct #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42ed424 to
c7b68fa
Compare
This commit consolidates all Grafana-related configuration into a single GrafanaConfig struct that includes URL, API key, and debug flag. This simplifies the configuration management and provides a cleaner API for programmatic usage. Changes: - Introduce GrafanaConfig struct containing Debug, URL, and various auth fields - Update all context functions to use the consolidated config - Update tests to use the new configuration approach This makes it easier to pass configuration around and provides a foundation for future configuration options.
c7b68fa to
a02d814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit consolidates all Grafana-related configuration into a single GrafanaConfig struct that includes URL, API key, and debug flag. This simplifies the configuration management and provides a cleaner API for programmatic usage.
Changes:
This makes it easier to pass configuration around and provides a foundation for future configuration options. For example, if we are to add custom TLS certs (#164) then we can include it on the config, rather than having to add a whole new set of context management functions.