refactor: extract Grafana Client creation from context functions #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bunch of duplicated code when creating the Grafana client from context, and I want to be able to do this in tests too, so this just refactors the code for later.
sd2k
added a commit
that referenced
this pull request
May 16, 2025
Using the refactored NewGrafanaClient function from PR #127.
* Add log lines when creating Sift investigation Should help debug issues when running Sift tools. * Include Grafana client in cloud test context Using the refactored NewGrafanaClient function from PR #127. * Fetch multiple investigations in tests, in case the first one has no analyses This can happen if, for example, an investigation was run with a scope that didn't find any logs, and so no analyses were created. * Add test for finding error pattern logs This relies on a new Loki datasource being added to the mcptests instance, which points to our dev logs. We probably want to get rid of this and use different logs; I'll look into how we can do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bunch of duplicated code when creating the Grafana client from
context, and I want to be able to do this in tests too, so this just refactors
the code for later.