Tool descriptions update #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the tool descriptions across several packages to provide more detailed guidance and examples on their usage. The changes aim to enhance clarity by expanding on the available parameters, return values, and usage scenarios for each tool.
- Updated descriptions for Grafana dashboards, Prometheus queries, OnCall schedules and shifts, Loki queries, incidents, datasources, dashboards, and alerting tools
- Added examples and extra details (such as supported pagination, filtering, and default behaviors) to improve user understanding
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/search.go | Updated the dashboard search tool description to be more detailed |
| tools/prometheus.go | Expanded Prometheus tool descriptions with specifics on query types and pagination |
| tools/oncall.go | Enhanced OnCall tool descriptions to include filtering details and return summaries |
| tools/loki.go | Detailed descriptions for Loki tools with default values and example outputs |
| tools/incident.go | Revised incident tool descriptions to include additional metadata and context |
| tools/datasources.go | Updated datasource tool descriptions with comprehensive details |
| tools/dashboard.go | Improved dashboard retrieval description with expanded information |
| tools/alerting.go | Refined alerting tool descriptions with examples and detailed response fields |
f659c73 to
f19b1be
Compare
sd2k
reviewed
Apr 28, 2025
tools/dashboard.go
Outdated
Comment on lines
67
to
70
| <<<<<<< HEAD | ||
| UpdateDashboard.Register(mcp) | ||
| ======= | ||
| >>>>>>> 5a539dd (improve search and dashboard descriptions) |
There was a problem hiding this comment.
whaaaat? I resolved this.. no idea how it got committed like that :(
Co-authored-by: Ben Sully <ben.sully@grafana.com>
Co-authored-by: Ben Sully <ben.sully@grafana.com>
c3f7323 to
edd8d59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tool descriptions, add more descriprive text and add a couple of examples.
The provided e2e tests are not enough to prove that those are improved descriptions but for now I followed guidelines from anthropic.
Closes 48