Skip to content

Check if datasource exists before querying #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

Check if datasource exists before querying #84

merged 2 commits into from
Apr 11, 2025

Conversation

ioanarm
Copy link
Contributor

@ioanarm ioanarm commented Apr 7, 2025

Related to 66

@ioanarm ioanarm marked this pull request as ready for review April 7, 2025 10:37
@ioanarm ioanarm requested a review from a team as a code owner April 7, 2025 10:37
csmarchbanks
csmarchbanks reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but also, could we just do it based on the response code from the main call? If it is a 404 return this message, or is it some other error?

@ioanarm ioanarm merged commit 78e604e into main Apr 11, 2025
5 checks passed
@ioanarm ioanarm deleted the descriptive-error-for-wrong-datasource branch April 11, 2025 07:25
ioanarm added a commit that referenced this pull request Apr 22, 2025
@ioanarm
Check if datasource exists before querying (#84)
b210728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csmarchbanks csmarchbanks csmarchbanks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioanarm @csmarchbanks