Add listing all contact points with pagination #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
ioanarm
reviewed
Apr 7, 2025
There was a problem hiding this comment.
Thanks so much for your contribution @sunwupark !
One small comment from my side! :)
|
I have also removed the page parameter from the alert test file. |
ioanarm
reviewed
Apr 7, 2025
tools/alerting.go
Outdated
| return result | ||
| } | ||
|
|
||
| func applyContactPointPagination(items []*models.EmbeddedContactPoint, limit int) ([]*models.EmbeddedContactPoint, error) { |
There was a problem hiding this comment.
tiny last comment, can we change the name of this function now?
There was a problem hiding this comment.
Would you be okay with renaming the function to applyLimitToContactPoints? I think it accurately reflects the current functionality.
|
yup! changed and commited |
ioanarm
pushed a commit
that referenced
this pull request
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added listContactPoints function to fetch and paginate contact points from Grafana.
Supports filtering by name and returns summarized data (UID, Name, Type).
Tests included for pagination, filtering, and invalid parameters.