feat(helm): add dnsconfig to all missing resources #18903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroepke
reviewed
Aug 20, 2025
| @@ -53,6 +53,10 @@ spec: | |||
| hostAliases: | |||
| {{- toYaml . | nindent 8 }} | |||
| {{- end }} | |||
| {{- with .Values.bloomGateway.dnsConfig }} | |||
There was a problem hiding this comment.
What did you think about this? Have a common value which can be overridden by more global one?
Suggested change
| {{- with .Values.bloomGateway.dnsConfig }} | |
| {{- with default .Values.bloomGateway.dnsConfig | default .Values.loki.dnsConfig }} |
There was a problem hiding this comment.
yes, excellent idea. will do.
jkroepke
reviewed
Aug 21, 2025
There was a problem hiding this comment.
Could you add loki.dnsConfig to
https://github.com/grafana/loki/blob/main/production/helm/loki/ci/non-default-values.yaml
Consider something simple, which wont break the CI.
So it's part of the CI? Thanks.
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Yes, added a case for default and and an override one of the components |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR