Browser tests stability #4855
Merged
Browser tests stability #4855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test doesn't really have any reason to be parallel, but it likely was very flaky due to it.
This seems to have some cases where it will not close the browser otherwise. It doesn't seem to have any other side effects.
This seems to be completely unused - maybe it was needed before.
This both makes it so we do not have two different ways of starting browser in the test. But also doesn't start separate browsers just to setup file servers and then others through startIteration.
|
Please review commit by commit as otherwise it will be a lot harder. I can break this up in separate PRs if that will be better - I expected a lot more of the first PRs, which meant I didn't want to break it down. |
joanlopez
approved these changes
Jun 16, 2025
ankur22
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Try to make browser tests more stable once again.
Part of the focus here was to run tests one by one and try to figure out which tests are leaving browsers that never die.
As part of this some other small fixes were added.
The
startIterationwas removed mostly due to it mostly being used alongsidenewTestBrowser, leading to multiple browsers started per test.Why?
Browser test are often the reason for CI tests to fail, and most of them seem to be due to performance problems - likely due to too many browsers running at the same time.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)