run CI/CD tests also on arm #4848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3559fc0 to
fadd08e
Compare
This comment has been minimized.
This comment has been minimized.
01b28f3 to
99eca80
Compare
|
Tired to use crocochrome for this in 99eca80, but unfortunately that did not work: The test suite includes tests for the lifecycle of the built-in browser process manager, so that's not an option. |
61a70ac to
00fb72e
Compare
joanlopez
reviewed
Jun 13, 2025
mstoykov
previously approved these changes
Jun 13, 2025
mstoykov
approved these changes
Jun 13, 2025
joanlopez
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables CI/CD pipelines to additionally run on arm machines, more precisely on
ubuntu-24.04-arm. This runner is provided by Github to the general public in beta quality, and is documented here: https://github.com/actions/partner-runner-images/blob/main/images/arm-ubuntu-24-image.mdRunning CI on arm is a first step towards increasing our confidence on the reliability of k6 and browser in this platform.
Some considerations for reviewers:
ubuntu-24.04,ubuntu-24.04-armdoes not come with chrome or chromium preinstalled, thus the reason of the conditional "install chromium" step.google-chromebinary, as opposed to chromium:k6/.github/workflows/browser_e2e.yml
Line 64 in b60a083