Skip to content

Use consistent error messages in the execution config options #4832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2025
Merged

Use consistent error messages in the execution config options #4832

merged 2 commits into from
Jun 5, 2025

Conversation

inancgumus
Copy link
Contributor

@inancgumus inancgumus commented Jun 5, 2025 •
edited
Loading

What?

Uses consistent error messages in the execution config options.

Why?

See grafana/k6-cloud#1056.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: @joanlopez would update it.

Related PR(s)/Issue(s)

Closes grafana/k6-cloud#1056

@inancgumus inancgumus added this to the v1.1.0 milestone Jun 5, 2025
@inancgumus inancgumus self-assigned this Jun 5, 2025
@inancgumus inancgumus force-pushed the fix/err-msg-scenarious branch from b44f756 to 9b13c07 Compare June 5, 2025 13:51
@inancgumus inancgumus marked this pull request as ready for review June 5, 2025 14:12
@inancgumus inancgumus requested a review from a team as a code owner June 5, 2025 14:12
@inancgumus inancgumus requested review from mstoykov, oleiade and ankur22 and removed request for a team, oleiade and mstoykov June 5, 2025 14:12
@inancgumus inancgumus changed the title Fix scenario shortcut multiple usage errors Use consistent errors in the execution config options Jun 5, 2025
@inancgumus inancgumus changed the title Use consistent errors in the execution config options Use consistent error messages in the execution config options Jun 5, 2025
@inancgumus inancgumus merged commit d3400a6 into master Jun 5, 2025
37 of 38 checks passed
@inancgumus inancgumus deleted the fix/err-msg-scenarious branch June 5, 2025 14:50
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

@codebien codebien codebien approved these changes

@joanlopez joanlopez joanlopez approved these changes

Assignees

@inancgumus inancgumus

Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@inancgumus @ankur22 @codebien @joanlopez