Prevent testcov running on public forks #4837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't retrieve secrets for public forks. Otherwise:
Run grafana/shared-workflows/actions/get-vault-secrets@get-vault-secrets/v1.2.1
Run ${GITHUB_ACTION_PATH}/translate-secrets.bash
Secrets that will be queried from Vault:
ci/data/repo/grafana/k6/CODECOV_TOKEN CODECOV_TOKEN | CODECOV_TOKEN;
Run actions/github-script@60a0d83
Error: Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable
at OidcClient.<anonymous> (/home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:585:23)
at Generator.next (<anonymous>)
at /home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:522:71
at new Promise (<anonymous>)
at __webpack_modules__.8041.__awaiter (/home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:518:12)
at OidcClient.getIDToken (/home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:571:16)
at Object.<anonymous> (/home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:421:46)
at Generator.next (<anonymous>)
at /home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:133:71
at new Promise (<anonymous>)
Error: Unhandled error: Error: Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable
cecab14 to
786c5db
Compare
codebien
previously approved these changes
Jun 6, 2025
8 tasks
joanlopez
reviewed
Jun 9, 2025
There was a problem hiding this comment.
Out of curiosity; I see the condition (i.e. if) is only set for the step to retrieve the token, does that mean that, when this workflow is executed for a fork, the step right after this one (the one that uploads coverage to Codecov) will fail because it will use a blank token?
If so, I guess it would be better if we can skip that one as well and thus prevent confusing errors.
Other than that, it looks good!
codebien
approved these changes
Jun 9, 2025
joanlopez
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
CODECOV_TOKENfor public forks.Why?
We can't retrieve secrets for public forks (example). Otherwise, we see:
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Updates grafana/k6-cloud#3525