Skip to content

Conversation

inancgumus
Copy link
Contributor

@inancgumus inancgumus commented Jun 2, 2025

What?

Use CODECOV_TOKEN from Vault instead of Github.

This is the first step. I'll soon update the other parts of the workflows.

Why?

Security.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link

Related PR(s)/Issue(s)

Updates grafana/k6-cloud#3495

@inancgumus inancgumus added this to the v1.1.0 milestone Jun 2, 2025
@inancgumus inancgumus self-assigned this Jun 2, 2025
@inancgumus inancgumus marked this pull request as ready for review June 2, 2025 21:26
@inancgumus inancgumus requested a review from a team as a code owner June 2, 2025 21:26
@inancgumus inancgumus requested review from mstoykov and oleiade and removed request for a team June 2, 2025 21:26
@inancgumus inancgumus changed the title Use CODECOV_TOKEN from Vault instead of Github Use CODECOV_TOKEN from Vault Jun 2, 2025
@inancgumus inancgumus requested review from codebien and joanlopez and removed request for mstoykov and oleiade June 4, 2025 18:18
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
@inancgumus inancgumus requested a review from codebien June 5, 2025 13:04
@inancgumus inancgumus merged commit d9170f6 into master Jun 5, 2025
35 of 38 checks passed
@inancgumus inancgumus deleted the vault-testcov branch June 5, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants