Skip to content

skip binary provisioning for help commands #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

skip binary provisioning for help commands #4753

merged 1 commit into from
Apr 30, 2025

Conversation

pablochacin
Copy link
Contributor

What?

Skip baniry provisioning for help commands

Why?

Help should be provided by the currently running k6 binary

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@pablochacin
skip binary provisioning for help commands
9ffe863 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin pablochacin marked this pull request as ready for review April 30, 2025 08:55
@pablochacin pablochacin requested a review from a team as a code owner April 30, 2025 08:55
@pablochacin pablochacin requested review from oleiade and the-it and removed request for a team April 30, 2025 08:55
@pablochacin pablochacin mentioned this pull request Apr 30, 2025
Merged
14 tasks
@pablochacin pablochacin requested a review from codebien April 30, 2025 09:55
@codebien codebien merged commit eed742e into feat/binary-provisioning Apr 30, 2025
22 of 28 checks passed
@codebien codebien deleted the binary-provisioning/skip-help-command branch April 30, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebien codebien codebien approved these changes

@oleiade oleiade Awaiting requested review from oleiade oleiade was automatically assigned from grafana/k6-core

@the-it the-it Awaiting requested review from the-it the-it was automatically assigned from grafana/k6-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablochacin @codebien