Skip to content

Try to fix lint GHA #4750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2025
Merged

Try to fix lint GHA #4750

merged 2 commits into from
Apr 29, 2025

Conversation

mstoykov
Copy link
Contributor

What?

Try to fix the lint github action.

Why?

Lint action needs to be reusable in different repos. And if used in grafana/k6 it needs to the config from the PR- otherwise use the one from master.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@mstoykov mstoykov requested a review from a team as a code owner April 29, 2025 13:21
@mstoykov mstoykov requested review from the-it and joanlopez and removed request for a team April 29, 2025 13:21
@mstoykov mstoykov requested review from ankur22 and codebien and removed request for the-it April 29, 2025 13:28
@mstoykov
Copy link
Contributor Author

My only explanation on this is that not using env.* within a template doesn't trigger the || and it is just an empty string 🤷

@mstoykov mstoykov merged commit 3f51f6a into master Apr 29, 2025
27 of 28 checks passed
@mstoykov mstoykov deleted the lintActionFix branch April 29, 2025 13:48
@mstoykov mstoykov added this to the v1.1.0 milestone Jun 16, 2025
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inancgumus inancgumus inancgumus approved these changes

@codebien codebien codebien approved these changes

@joanlopez joanlopez Awaiting requested review from joanlopez joanlopez is a code owner automatically assigned from grafana/k6-core

@ankur22 ankur22 Awaiting requested review from ankur22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @inancgumus @codebien