Skip to content

Drop the redundant NO_COLOR detection #4686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

Drop the redundant NO_COLOR detection #4686

merged 1 commit into from
Apr 14, 2025

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Apr 11, 2025 •
edited
Loading

What?

It drops a redundant logic about NO_COLOR.

Why?

Because we are already checking here

k6/cmd/state/state.go

Lines 188 to 192 in b61ca16

// Support https://no-color.org/, even an empty value should disable the
// color output from k6.
if _, ok := env["NO_COLOR"]; ok {
result.NoColor = true
}

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

@codebien codebien self-assigned this Apr 11, 2025
@codebien codebien mentioned this pull request Apr 11, 2025
Merged
14 tasks
@codebien codebien marked this pull request as ready for review April 14, 2025 13:02
@codebien codebien requested a review from a team as a code owner April 14, 2025 13:02
@codebien codebien requested review from oleiade and joanlopez and removed request for a team April 14, 2025 13:02
oleiade
oleiade approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codebien codebien merged commit f042559 into master Apr 14, 2025
28 checks passed
@codebien codebien deleted the remove-duplicated-nocolor-logic branch April 14, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiade oleiade oleiade approved these changes

@joanlopez joanlopez joanlopez approved these changes

Assignees

@codebien codebien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebien @oleiade @joanlopez