Skip to content

Move k6 js module to internal as preparations for v1.0.0 #4676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Move k6 js module to internal as preparations for v1.0.0 #4676

merged 1 commit into from
Apr 9, 2025

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Apr 8, 2025

What?

Move the js module k6 under the internanal package.

Why?

Reduce k6's public API

This wasn't previously done due to the exported ErrCheckInInitContext being used in a couple of extensions that should likely come up with their own errors.

Related to #4133

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@mstoykov
Move k6 js module to internal as preparations for v1.0.0
5360c4d 
This wasn't previously done due to the exported `ErrCheckInInitContext`
being used in a couple of extensions that should likely come up with
their own errors.

Related to #4133
@mstoykov mstoykov added the breaking change for PRs that need to be mentioned in the breaking changes section of the release notes label Apr 8, 2025
@mstoykov mstoykov added this to the v1.0.0 milestone Apr 8, 2025
@mstoykov mstoykov requested a review from a team as a code owner April 8, 2025 08:46
@mstoykov mstoykov requested review from inancgumus and joanlopez and removed request for a team April 8, 2025 08:46
@mstoykov
Copy link
Contributor Author

mstoykov commented Apr 8, 2025 •
edited
Loading

The extensions in question are :

This was referenced Apr 8, 2025
Merged
Merged
@mstoykov mstoykov merged commit aa1e289 into master Apr 9, 2025
28 of 29 checks passed
@mstoykov mstoykov deleted the movek6Module branch April 9, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inancgumus inancgumus inancgumus approved these changes

@joanlopez joanlopez joanlopez approved these changes

Assignees
No one assigned
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @inancgumus @joanlopez