Move CSV output to internal as preparations for v1.0.0 #4675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was not moved before as a utility function `IsStringInSlice` used by a now not maintained extension: - https://github.com/Maksimall89/xk6-output-clickhouse As that dependency doesn't make any sense it was planned to be moved either way. But as the extension is now not maintained and has not merged previous PRs to fix breaking changes, it is even more of a reason to move forward. Related to #4133
inancgumus
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Move the CSV output under internal package
Why?
Reducing public API
This was not moved before as a utility function
IsStringInSliceused by a now not maintained extension:As that dependency doesn't make any sense it was planned to be moved either way. But as the extension is now not maintained and has not merged previous PRs to fix breaking changes, it is even more of a reason to move forward.
Related to #4133
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)