UX: fix anchor link in the error message #4612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @tanurrra 👋🏻 For this fix, much appreciated 🙇🏻 |
|
@tanurrra CI reports that in order for us to be able to merge this, you should sign our CLA agreement. If you're fine with it, you can proceed by clicking on the |
Signed-off-by: Tatyana Velikanova <22240559+tanurrra@users.noreply.github.com>
codebien
requested changes
Mar 11, 2025
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
codebien
requested changes
Mar 12, 2025
oleiade
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update anchor link to the official docs in the error message
The moduleSpecifier "%s" couldn't be found on local disk. New anchor link ishttps://grafana.com/docs/k6/latest/using-k6/modules/#local-modules-2.Why?
Anchor link
https://grafana.com/docs/k6/latest/using-k6/modules/#using-local-modules-with-dockerin the error messageThe moduleSpecifier "%s" couldn't be found on local disk...is not up-to date, so anchor link is being resolved to the beginning of the page.Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)