Run WPT tests with -race and fix race in ReadableStream.cancel
#4544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
previously approved these changes
Feb 13, 2025
Previously the reject of the promise was happening on the event loop, but the argument which is a TypeError was created off it in a goroutine. The goroutine isn't really needed, so the code is somewhat simplified and handling more corner cases.
inancgumus
approved these changes
Feb 13, 2025
-race and fix race in ReadableStream.cancel
codebien
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Run wpt tests with -race and fix race in ReadableStream.cancel
Why?
So we catch race conditions
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)