browser: fix some mappings and remove overzealous TODOs #4534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While trying to fix some mappings that originally I recognized as places that races are possible, I found that is not the case. As mappings are just a map that is methods/fields to their values, as long as no usage the runtime happens outside of any mapping it is fine. This is the case for most cases, this fixes the one that isn't.
inancgumus
approved these changes
Feb 10, 2025
joanlopez
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
More fixes for browser mappings and removing some overzealous TODOs
Why?
While trying to fix some mappings that originally I recognized as places that races are possible, I found that is not the case.
As mappings are just a map that is methods/fields to their values, as long as no usage the runtime happens outside of any mapping it is fine.
This is the case for most cases, this fixes the one that isn't.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)